-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Change structural types scheme #9180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I reverted the previous attempt to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @odersky. I have some small comments. The implementation looks good, but I really think we should have a test with contextual parameters in the selectDynamic
and applyDynamic
methods, which was at least half of the point of this new scheme.
Make Selectable a marker trait without any members.
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a SemanticDB test that failed in bootstrap:
[info] Test dotty.tools.dotc.semanticdb.SemanticdbTests.expectTests started
[error] check file /__w/dotty/dotty/tests/semanticdb/expect/Advanced.expect.scala does not match generated.
If you meant to make a change, replace the expect file by:
mv /__w/dotty/dotty/tests/semanticdb/expect/Advanced.expect.scala.out /__w/dotty/dotty/tests/semanticdb/expect/Advanced.expect.scala
inspect with:
diff /__w/dotty/dotty/tests/semanticdb/expect/Advanced.expect.scala /__w/dotty/dotty/tests/semanticdb/expect/Advanced.expect.scala.out
Or else update all expect files with
sbt 'dotty-compiler-bootstrapped/test:runMain dotty.tools.dotc.semanticdb.updateExpect'
[error] Test dotty.tools.dotc.semanticdb.SemanticdbTests.expectTests failed: java.lang.AssertionError: 1 errors in expect test., took 1.397 sec
[error] at dotty.tools.dotc.semanticdb.SemanticdbTests.runExpectTest(SemanticdbTests.scala:82)
[error] at dotty.tools.dotc.semanticdb.SemanticdbTests.expectTests(SemanticdbTests.scala:39)
[error] ...
[info] Test run finished: 1 failed, 0 ignored, 1 total, 1.398s
but otherwise LGTM :)
Make Selectable a marker trait without any members.