Allow overloads between fields and methods for Java code #9116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
overload-field-meth
branch
from
b11878f to
407d39d
Compare
odersky
requested changes
Jun 8, 2020
|
|
||
| /** Does this signature potentially clash with `that` ? */ | ||
| def clashes(that: Signature)(implicit ctx: Context): Boolean = | ||
| matchDegree(that) == FullMatch | ||
|
|
||
| /** name.toString == "" or name.toString == "_" */ | ||
| private def isWildcard(name: TypeName) = name.isEmpty || name == tpnme.WILDCARD | ||
| private def isWildcard(name: TypeName) = name == tpnme.WILDCARD |
There was a problem hiding this comment.
Rename to isWildcardOrEmpty
There was a problem hiding this comment.
Actually that commit removed the name.isEmpty check, so the current name of that method should be accurate.
| "have matching parameter types." | ||
| case Signature.MatchDegree.FullMatch => | ||
| case MethodNotAMethodMatch => | ||
| "both have no parameters" |
smarter
force-pushed
the
overload-field-meth
branch
from
407d39d to
741685d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7132.