Fix #9088: Fix problematic code in productMirror #9089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
commented
May 31, 2020
| @@ -279,7 +279,7 @@ class Synthesizer(typer: Typer)(using @constructorOnly c: Context): | |||
| case mirroredType: HKTypeLambda => | |||
| val elems = | |||
| mirroredType.derivedLambdaType( | |||
| resType = TypeOps.nestedPairs(accessors.map(mirroredType.memberInfo(_).widenExpr)) | |||
There was a problem hiding this comment.
mirroredType.memberInfo(_) makes no sense here. mirroredType is a type lambda, and as such not a legal prefix on which we can take a memberInfo. So I changed to just _.info which avoids the crash. However, I have no idea whether that's correct.
|
@milessabin This looks still fishy to me. But I have no idea how to formulate a correct derivation in the higher-kinded case. |
|
This is merged as part of #9090. @milessabin it would still be good if you could take a look at the changes to the higher-kinded product mirror materialization. |
|
I'm not seeing anything obviously problematic about the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.