Skip to content

[resubmitted] Fix #9061: Treat type F <: [X] => G like type F[X] <: G. #9086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented May 30, 2020

Accidentally merged in #9084, reverted and resubmitted because the community build started failing:

2020-05-30T15:04:52.6008148Z [info] Set current project to effpi (in build file:/__w/dotty/dotty/community-build/community-projects/effpi/)
2020-05-30T15:04:58.4723186Z [error] -- [E007] Type Mismatch Error: /__w/dotty/dotty/community-build/community-projects/effpi/src/main/scala/ActorDSL.scala:118:13 
2020-05-30T15:04:58.4723812Z [error] 118 |    pdsl.rec(RecA)(beh >> pdsl.loop(RecA))
2020-05-30T15:04:58.4724173Z [error]     |             ^^^^
2020-05-30T15:04:58.4724507Z [error]     |             Found:    effpi.actor.dsl.RecA.type
2020-05-30T15:04:58.4724861Z [error]     |             Required: effpi.process.RecVar[A]
2020-05-30T15:04:59.5859259Z [error] -- [E007] Type Mismatch Error: /__w/dotty/dotty/community-build/community-projects/effpi/src/main/scala/ActorDSL.scala:118:36 
2020-05-30T15:04:59.5859978Z [error] 118 |    pdsl.rec(RecA)(beh >> pdsl.loop(RecA))
2020-05-30T15:04:59.5860354Z [error]     |                                    ^^^^
2020-05-30T15:04:59.5860740Z [error]     |                                   Found:    effpi.actor.dsl.RecA.type
2020-05-30T15:04:59.5861157Z [error]     |                                   Required: effpi.process.RecVar[A]
2020-05-30T15:05:00.0746454Z [error] two errors found
2020-05-30T15:05:00.1342256Z [error] (Compile / compileIncremental) Compilation failed

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@odersky
Copy link
Contributor

odersky commented May 30, 2020

@alcestes I had to disable effpi in the community build since it started failing with the errors shown above after a variance soundness hole was fixed. Could you take a look to see whether you can fix it so that it compiles again?

smarter added a commit to smarter/effpi that referenced this pull request May 30, 2020
@smarter
Copy link
Member Author

smarter commented May 30, 2020

I'm not sure if the problem is really in effpi, I can get it to compile with the following commit: smarter/effpi@5270291. Dotty is misinterpreting the type bounds without explicit kinding, so either we should disallow them, or support them properly.

@odersky
Copy link
Contributor

odersky commented May 31, 2020

I think we should disallow these bounds. But that should be in a separate PR since that will require more code to be changed. Can you add the changes to effpi so that we can close this one?

@odersky odersky assigned smarter and unassigned odersky May 31, 2020
Requires updating effpi to use explicit kinding, todo: disallow
non-explicit kinding.
@smarter smarter merged commit b852e14 into scala:master May 31, 2020
@smarter smarter deleted the fix-#9061-2 branch May 31, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants