Fix #7778: infer parameter type for contextual functions #9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a contextual function of the form
(using x1, ..., xN) => f
If `f` is a contextual function type of the form `(T1, ..., TN) ?=> T`,
then give the type `T1` to `x1` and so on.
odersky
reviewed
Jun 1, 2020
| lazy val calleeType: Type = fnBody match { | ||
| lazy val calleeType: Type = untpd.stripAnnotated(fnBody) match { | ||
| case ident: untpd.Ident if isContextual => | ||
| val tp = typedIdent(ident, WildcardType).tpe.widen |
There was a problem hiding this comment.
tp is commonly used for types. I suggest ident1 instead.
There was a problem hiding this comment.
Here tp is a type, not a tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7778: infer parameter type for contextual functions
Given a contextual function of the form
If
fis a contextual function type of the form(T1, ..., TN) ?=> T,then give the type
T1tox1and so on.