Skip to content

Add Tuple.{apply, unapply} #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 25, 2020

Part of #9033

@nicolasstucki nicolasstucki self-assigned this May 25, 2020
Change all tests to make them use this new syntax
@nicolasstucki nicolasstucki force-pushed the add-Tuple-apply-and-unapply branch from 052a094 to 5b462f2 Compare May 25, 2020 16:20
@nicolasstucki nicolasstucki marked this pull request as ready for review May 25, 2020 18:46
@nicolasstucki nicolasstucki requested a review from liufengyun May 25, 2020 18:46
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes alone, it is not obvious that this is an improvement in terms of programming experience.

Maybe also add the other half so that the benefits will be more noticeable.

@nicolasstucki
Copy link
Contributor Author

To add the next step I need this change in the reference compiler. Otherwise I would need to duplicate some rather large file in the bootstrapped/non-bootstraped library and lose thier history.

It is also orthogonal self contained change compared to the other changes. Hence a good candidate for its own PR.

@nicolasstucki nicolasstucki requested a review from liufengyun May 26, 2020 05:15
@liufengyun
Copy link
Contributor

What about pushing the design in another PR (no need to be green), so that we can see the proposal as a whole? Seeing the solution as a whole might consolidate/invalidate some assumptions, or give rise to better ideas.

@nicolasstucki
Copy link
Contributor Author

This constructor/extractor are useful on their own even if we do not do the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants