Skip to content

compile dotty with Ysemanticdb #8983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2020
Merged

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented May 14, 2020

fix #8970 fix #8954

fix a number of issues with semanticdb generation

  • support scala 2 def macros
  • support var overloads
  • support literal types and byname params in constructors (by removing unneccesary code)
  • support local definitions from inlined macro generated trees (where symbol has no span)
  • prevent infinite recursion on traversal of annotations
  • support inlined macro trees from another file
  • do not emit occurence for <special-ops>.throw
  • inlined trees have position in the file of the callsite, not implementation

this also compiles all of the vulpix tests with Ysemanticdb option and the bootstrapped projects (localised to 1 commit)

@bishabosha
Copy link
Member Author

bishabosha commented May 15, 2020

this will fail until I rebase it on a PR to always provide spans if possible for symbols from TASTy

Now implemented change to provide spans from tasty when semanticdb is set

@bishabosha
Copy link
Member Author

@smarter I've added a change here so that compiler newRun enables ReadPositions if Ysemanticdb setting is true

@bishabosha bishabosha merged commit d463a9e into scala:master May 19, 2020
@bishabosha bishabosha deleted the fix-#8970 branch May 19, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semanticdb: assertion failed in runMacro test Generation of semanticdb for dotty codebase fails
2 participants