bundle of doc improvements #8974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
commented
May 13, 2020
odersky
requested changes
May 20, 2020
and some other improvements
|
@odersky I see my confusion, I added a sentence to implicit-resolution so that others aren't: https://github.com/lampepfl/dotty/pull/8974/files#diff-843899951c4ebf33685c569656144812R5 |
odersky
reviewed
May 25, 2020
|
@robstoll Great. Yes, that sentence you added is important. I just made a suggestion to clarify it further. Otherwise all is good. |
Co-authored-by: odersky <[email protected]>
odersky
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.