Skip to content

Fix #8520: Add Reflection.Symbol.typeMembers #8962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

Fix #8520: Add Reflection.Symbol.typeMembers #8962

merged 1 commit into from
May 12, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this May 12, 2020
@nicolasstucki nicolasstucki linked an issue May 12, 2020 that may be closed by this pull request
TASTY: no way to access type constructor of an AppliedType and explore its argument variance #8520
Closed
@nicolasstucki nicolasstucki marked this pull request as ready for review May 12, 2020 16:03
@anatoliykmetyuk anatoliykmetyuk merged commit eeda658 into scala:master May 12, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the fix-#8520-2 branch May 12, 2020 16:33
@LPTK
Copy link
Contributor

LPTK commented May 16, 2020

/** Type member directly declared in the class */

@msosnicki @anatoliykmetyuk Why not name this typeDeclarations, and have typeMembers list all type members? This naming convention not only makes more sense, but would also be consistent with the Scala 2 macros convention.

Also, is it planned to have a way to list all the members of a type? (Not just type members.)

@anatoliykmetyuk
Copy link
Contributor

Sounds useful to me, but maybe @nicolasstucki can comment more on this.

@LPTK
Copy link
Contributor

LPTK commented May 18, 2020

Thanks for the answer. Yes, I think it's a pretty important feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk approved these changes

Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TASTY: no way to access type constructor of an AppliedType and explore its argument variance
3 participants
@nicolasstucki @LPTK @anatoliykmetyuk