Fix #7839: Improve error message for implicit parameters #8960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
assigned adriaanm and anatoliykmetyuk and unassigned nicolasstucki and adriaanm
| | ^ | ||
| | Malformed macro parameter: dummyImplicit | ||
| | | ||
| | Parameters may only be: |
There was a problem hiding this comment.
Why does it resolve DummyImplicit at all if it is neither of the two cases below?
There was a problem hiding this comment.
This is a static check that happens after typechecking. We do not modify in any way the typing of expressions within top level splices, we only restrict it based terms that can be interpreted when evaluating the macro.
anatoliykmetyuk
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.