Skip to content

Make QuoteContext a trait #8941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

This will allow us to replace the implementation in the future if needed.

This will allow us to replace the implementation in the future if needed.
@nicolasstucki nicolasstucki requested a review from liufengyun May 11, 2020 08:44
@nicolasstucki nicolasstucki self-assigned this May 11, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review May 11, 2020 09:00
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 5d5a3dd into scala:master May 11, 2020
@nicolasstucki nicolasstucki deleted the make-quotecontext-a-trait branch May 11, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants