Check that access to context base is singlethreaded. #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this file shouldn't be deleted. It will break tests in CI and new clones of the repo. |
|
But sbt deletes .keep. Or it flips it around all the time! Can you push a .gitignore which makes that problem go away? |
ContextBase is not intended to be threadsafe, We now test that indeed it is not shared by compileUnits calls operating on different threads.
odersky
force-pushed
the
check-singlethreaded
branch
from
105e8c0 to
5b2d94a
Compare
|
Force pushed a version that keeps out/.keep. |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Oct 31, 2015
Check that access to context base is singlethreaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextBase is not intended to be threadsafe, We now test that
indeed it is not shared by compileUnits calls operating on
different threads. Review by @DarkDimius.