Enable many javalib/util/* tests other than Sets for Scala.js #8926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 9, 2020
|
Working on simple stuff (I think) for #7113 as I am still new to working on compilers. |
Partial fix for lampepfl#7113 Just enabling the tests which already passed. It looks like the upstream tests need updating for the Set pieces.
squid314
force-pushed
the
feat/add-sjs-tests
branch
from
11e6bdb to
c484384
Compare
sjrd
approved these changes
May 9, 2020
|
@smarter Any opinion on the new format with one exclusion by line? |
|
It's not that many so it's fine. |
|
My reasoning was that it was easier to comment out one-by-one and it would be more obvious what changed even if you were adding several tests at a time. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.