Fix phase of context for denotation transformer #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def withPhase(pid: PhaseId): this.type = withPeriod(Period(runId, pid)) | ||
| def withPhase(phase: Phase): this.type = withPhase(phase.id) | ||
| override def withPhase(pid: PhaseId): this.type = withPeriod(Period(runId, pid)) | ||
| override def withPhase(phase: Phase): this.type = withPhase(phase.id) |
There was a problem hiding this comment.
Why would you want to override this? IIUC the superclass implementation does the same.
There was a problem hiding this comment.
Good catch. The second withPhase(phase: Phase) in class FreshContext can be deleted.
There was a problem hiding this comment.
This override is required, as otherwise returning type will be Context, and not FreshContext.
There was a problem hiding this comment.
Indeed. But that means, and I just realize that, that withPhase mutates the underlying object depending on its runtime type. @odersky I think this is a very bad idea. The methods should have a different name. (IMHO, the with methods of FreshContext should rather be called set)
|
LGTM otherwise. |
The phase is now always the phase on which the denotation transformer is defined.
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Mar 24, 2014
Fix phase of context for denotation transformer
DarkDimius
added a commit
that referenced
this pull request
Mar 24, 2014
Fix phase of context for denotation transformer
DarkDimius
added a commit
that referenced
this pull request
Mar 24, 2014
Fix phase of context for denotation transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phase is now always the phase on which the denotation transformer is defined.