Skip to content

Fix #8871: Detect explicit splices of quoted.Type[?] #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 4, 2020

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki nicolasstucki self-assigned this May 4, 2020
@nicolasstucki nicolasstucki force-pushed the fix-#8871 branch 2 times, most recently from 757eb95 to 3568dcf Compare May 4, 2020 08:11
@nicolasstucki nicolasstucki linked an issue May 4, 2020 that may be closed by this pull request
@nicolasstucki nicolasstucki marked this pull request as ready for review May 4, 2020 09:12
@nicolasstucki nicolasstucki marked this pull request as draft May 4, 2020 09:12
@nicolasstucki nicolasstucki marked this pull request as ready for review May 5, 2020 15:01
@nicolasstucki nicolasstucki requested a review from liufengyun May 5, 2020 15:02
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 93ef012 into scala:master May 6, 2020
@nicolasstucki nicolasstucki deleted the fix-#8871 branch May 6, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect explicitly spliced wildcard types
3 participants