Use transparent inline in the library #8756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
use-transparent-inline-in-the-library
branch
from
8447ab2 to
a8a1a4a
Compare
And add deprecation warnings for old syntax
nicolasstucki
force-pushed
the
use-transparent-inline-in-the-library
branch
from
a8a1a4a to
2548798
Compare
liufengyun
approved these changes
Apr 20, 2020
| @@ -8,7 +8,7 @@ object DottyPredef { | |||
| assertFail(message) | |||
| } | |||
|
|
|||
| inline final def assert(inline assertion: Boolean) <: Unit = { | |||
| transparent inline final def assert(inline assertion: Boolean): Unit = { | |||
| if (!assertion) | |||
| assertFail() | |||
| } | |||
There was a problem hiding this comment.
Maybe I miss something here, what is the purpose of making this white box, as the result type is Unit?
There was a problem hiding this comment.
If you write assert(false) the inclined expression becomes of type Nothing.
There was a problem hiding this comment.
It is like a ??? With a message
There was a problem hiding this comment.
Not sure if this should be supported thought
DieBauer
reviewed
Apr 21, 2020
DieBauer
reviewed
Apr 21, 2020
Co-Authored-By: Jens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit contains the interesting changes. The second only updates the syntax in the tests to make sure that the new version works properly.