Fix #8392: Remove parameter type bounds from scala.compiletime.ops.any types #8723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala#8392 String is not a subtype of AnyVal, so the type `==["", ""]` could not be applied. No type bound is preferable to a type bound of `Singleton` as it maintains the ability to have an unapplied type `Int == Int`, and is more in line with the `any` package name.
dottybot
reviewed
Apr 14, 2020
nicolasstucki
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8392
Stringis not a subtype ofAnyVal, so the type"" == ""could not be applied.As discussed in the issue, having no type bound on the parameters of the
==type is preferable to a type bound ofSingletonas it maintains the ability to have an unapplied typeInt == Int, and is more in line with theanypackage name.