Better cast elision, fix an issue with tailrec #8713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get rid of `asInstanceOf[T]` whenever the erased type of expression is a subtype of T. This allows us to produce leaner bytecode and also fixes scala#8712 since unnecessary asInstanceOf calls were preventing tailrec from working.
- Avoid using the generic Array constructor when possible - In the situation where we do need to use the generic Array constructor, add an expected type to make the example more realistic and reveal whether a checkcast is needed in bytecode to make use of the Array at all. With these changes, using Array or IArray produce the exact same bytecode.
nicolasstucki
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.