Make context available in TreeTransform.prepareForXX methods #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @DarkDimius @odersky |
|
It's not complete now: you should provide different context during |
|
Why it's not complete: in this implementation all mini-phases share same context(which they implicitly got from TreeTransformer), with will have period of first mini-phase in group. |
| @@ -432,7 +432,7 @@ object TreeTransforms { | |||
| var allDone = i < l | |||
| while (i < l) { | |||
| val oldT = result(i) | |||
| val newT = mutator(oldT, tree) | |||
| val newT = ctx.atPhase(oldT)(mutator(oldT, tree, _)) | |||
There was a problem hiding this comment.
@DarkDimius you are saying this line should be the following?
val newT = mutator(oldT, tree, info.contexts(i))
|
Updated |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Mar 21, 2014
Make context available in TreeTransform.prepareForXX methods
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "Avoid orphan param from default arg" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.