Cleanup inlined positions implementation #8648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
clenup-inlined-positions-implememtations
branch
from
7f2f83e to
9888224
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
clenup-inlined-positions-implememtations
branch
from
9888224 to
d611e3c
Compare
nicolasstucki
force-pushed
the
clenup-inlined-positions-implememtations
branch
from
d611e3c to
13f4eb7
Compare
Trees now have sources that can be used directly without the need of `enclosingInlineds` to track the current source. This new implemetation simply uses the tree positions directly and does not need to keep the context in sync with the `enclosingInlineds`.
nicolasstucki
force-pushed
the
clenup-inlined-positions-implememtations
branch
from
13f4eb7 to
83e28e3
Compare
nicolasstucki
assigned liufengyun and nicolasstucki and unassigned nicolasstucki and liufengyun
nicolasstucki
force-pushed
the
clenup-inlined-positions-implememtations
branch
from
24acf8a to
e1b34c7
Compare
liufengyun
approved these changes
Apr 2, 2020
| case tree: Bind => finalize(tree, untpd.Bind(tree.name, transform(tree.body))(curSource)) | ||
| def finalize(copied: untpd.Tree) = | ||
| val span = if tree.source == curSource then tree.span else callSpan | ||
| copied.withSpan(span).withAttachmentsFrom(tree).withTypeUnchecked(tree.tpe) |
There was a problem hiding this comment.
Do we need to change the tree.source?
There was a problem hiding this comment.
That is done by the cpyWithNewSource. This logic did not change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trees now have sources that can be used directly without the need of
enclosingInlinedsto track the current source. This new implemetation simply uses the tree positions
directly and does not need to keep the context in sync with the
enclosingInlineds.