Skip to content

Fix #7343: Detect inlined quotes #8642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Mar 31, 2020
@nicolasstucki nicolasstucki force-pushed the fix-#7343 branch 6 times, most recently from 643f624 to 77ba060 Compare April 3, 2020 07:24
@nicolasstucki nicolasstucki marked this pull request as ready for review April 3, 2020 13:16
@nicolasstucki nicolasstucki requested a review from liufengyun April 3, 2020 13:16
@nicolasstucki
Copy link
Contributor Author

This PR passed all the relevant teats

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This Inlined node not was added as part of a fix for issue scala#3898.
It was an ad-hoc patch that ended up causing more issues than fixes and
therfore is removed.
@nicolasstucki
Copy link
Contributor Author

Rebases and updates conflicts

@nicolasstucki nicolasstucki merged commit 59f7e65 into scala:master Apr 6, 2020
@nicolasstucki nicolasstucki deleted the fix-#7343 branch April 6, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants