Skip to content

Don’t suggest to import things that are already in scope #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Don’t suggest to import things that are already in scope #8640

merged 1 commit into from
Apr 22, 2020

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Mar 31, 2020 •
edited
Loading

Fixes #8051

dottybot
dottybot reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@julienrf julienrf force-pushed the fix/remove-suggestions-already-in-scope branch from 40aa842 to 07b6199 Compare March 31, 2020 15:49
@julienrf julienrf changed the title Fix/remove suggestions already in scope Don’t suggest to import things that are already in scope Mar 31, 2020
@julienrf julienrf linked an issue Mar 31, 2020 that may be closed by this pull request
Suggested import clauses should not include paths that are already part of the implicit scope #8051
Closed
@julienrf julienrf force-pushed the fix/remove-suggestions-already-in-scope branch 2 times, most recently from ed1088f to a59cdd5 Compare April 6, 2020 12:09
@julienrf julienrf marked this pull request as ready for review April 6, 2020 12:11
@smarter smarter requested a review from odersky April 7, 2020 18:59
@julienrf julienrf force-pushed the fix/remove-suggestions-already-in-scope branch from a59cdd5 to 6e1761d Compare April 15, 2020 08:14
@julienrf
Copy link
Contributor Author

I’ve just rebased the PR

odersky
odersky approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very nice improvement!

@odersky odersky merged commit 1931bc7 into scala:master Apr 22, 2020
@sjrd sjrd deleted the fix/remove-suggestions-already-in-scope branch April 22, 2020 10:44
@odersky odersky mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested import clauses should not include paths that are already part of the implicit scope
3 participants
@julienrf @odersky @dottybot