Skip to content

Properly inline DottyPredef.locally #8636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Properly inline DottyPredef.locally #8636

merged 1 commit into from
Mar 31, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 30, 2020 •
edited
Loading

Avoid creating unnecessary closure.

@nicolasstucki nicolasstucki force-pushed the properly-optimize-locally branch from a4e8c0f to 3b20476 Compare March 30, 2020 15:58
@nicolasstucki nicolasstucki marked this pull request as ready for review March 30, 2020 16:36
liufengyun
liufengyun approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 7a28eef into scala:master Mar 31, 2020
@nicolasstucki nicolasstucki deleted the properly-optimize-locally branch March 31, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun