Keep track of method parameter symbols #8597
Conversation
| /** If this is a method, the parameter symbols, by section. | ||
| * Both type and value parameters are included. Empty sections are skipped. | ||
| */ | ||
| final def paramss: List[List[Symbol]] = myParamss |
There was a problem hiding this comment.
This will need to be exposed from tasty-reflect to give access to parameter annotations. @nicolasstucki do you mind doing that ?
There was a problem hiding this comment.
I can do that once this is merged.
There was a problem hiding this comment.
Always keep annotations on value parameters for class methods
This commit doesn't match what scalac does. I have a PR which fixes all that at #8534 which was blocked so far because I couldn't get to the annotations on method parameters and shapeless has a test that relies on that (this is what I need the tasty-reflect change I mentioned above for)
|
Yes, I saw the commit message. #8534 also moves the annotations to the constructor but removes them from the derived parameters to match scalac. This is the change which is blocked on this PR. If getting annotations on the constructor is important for this PR then I can integrate my PR into this PR. |
|
@smarter: No, it's not important right now. It's just something I noted when I went through how modifiers are copied to value parameters. For the moment all I need to do is to copy a HasDefault parameter annotation correctly. I'll roll back the last commit then. |
Store the parameter symbols of a method in a `paramss` field of the method symbol. Parameter symbols are kept up-to-date until erasure.
Add a method `paramSymss` that mirrors the type structure of a method. Rename the old `paramss` to `rawParamss` to caution against naive uses.
|
Subsumed by #8637. |
Store the parameter symbols of a method in a
paramssfield of the method symbol.
Parameter symbols are kept up-to-date until erasure.