Skip to content

Add scodec to the community build #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpilquist
Copy link
Contributor

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@mpilquist mpilquist force-pushed the topic/scodec-community-build branch from 74bba1d to 60256f5 Compare March 22, 2020 13:48
@mpilquist mpilquist changed the title Added scodec to the community build Add scodec to the community build Mar 22, 2020
@anatoliykmetyuk
Copy link
Contributor

Thanks for adding this @mpilquist!

All the community projects exist in Dotty as forks of the original repos under dotty-staging organization. I've created such forks for your projects and added you to the repos:

https://github.com/dotty-staging/scodec-bits
https://github.com/dotty-staging/scodec

Could you make the submodules point to these repos?

Also, the build is failing because sbt.librarymanagement.ResolveException: Error downloading org.scalatest:scalatest_0.24:3.1.1. This is because in the community build, we do not have Scalatest 3.1.1, only 3.1.0-SNAP13. This means that for your projects to compile, you need to depend exactly on that version. I would recommend to try to update the dependency on the forks in the dotty-staging organization so that the original repo is not affected.

@mpilquist
Copy link
Contributor Author

mpilquist commented Mar 25, 2020

@anatoliykmetyuk Thanks!

Is there a way to run the community build locally? I knew this PR wasn't yet in a good state but wanted to see the output of CI in order to make progress.

@mpilquist mpilquist force-pushed the topic/scodec-community-build branch from 7406008 to 9f717da Compare March 25, 2020 14:12
@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Mar 25, 2020

Is there a way to run the community build locally?

You can do so by cloning the Dotty repo, launching SBT console from it and running the following commands from there:

community-build/testOnly dotty.communitybuild.CommunityBuildTest -- *scodec
community-build/testOnly dotty.communitybuild.CommunityBuildTest -- *scodecBits

@mpilquist
Copy link
Contributor Author

OK I think this is ready. Do you want me to close this and reopen a PR with a single commit? Alternatively, squash merging is fine.

@smarter
Copy link
Member

smarter commented Mar 26, 2020

Do you want me to close this and reopen a PR with a single commit?

You can squash your commits and push-force without closing/reopening.

@mpilquist mpilquist force-pushed the topic/scodec-community-build branch from 7682323 to 1dc7b37 Compare March 26, 2020 12:17
@mpilquist
Copy link
Contributor Author

Okay squashed. Thanks for all the help!

@anatoliykmetyuk anatoliykmetyuk merged commit 5ade75b into scala:master Mar 26, 2020
@anatoliykmetyuk
Copy link
Contributor

Thanks for contributing these tests @mpilquist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants