-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add scodec to the community build #8590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scodec to the community build #8590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
74bba1d
to
60256f5
Compare
Thanks for adding this @mpilquist! All the community projects exist in Dotty as forks of the original repos under dotty-staging organization. I've created such forks for your projects and added you to the repos: https://github.com/dotty-staging/scodec-bits Could you make the submodules point to these repos? Also, the build is failing because |
@anatoliykmetyuk Thanks! Is there a way to run the community build locally? I knew this PR wasn't yet in a good state but wanted to see the output of CI in order to make progress. |
7406008
to
9f717da
Compare
You can do so by cloning the Dotty repo, launching SBT console from it and running the following commands from there:
|
OK I think this is ready. Do you want me to close this and reopen a PR with a single commit? Alternatively, squash merging is fine. |
You can squash your commits and push-force without closing/reopening. |
7682323
to
1dc7b37
Compare
Okay squashed. Thanks for all the help! |
Thanks for contributing these tests @mpilquist! |
No description provided.