-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix xml-interpolator module reference #8560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xml-interpolator module reference #8560
Conversation
We started having it on in `lampepfl` but now that we need to update it from type to time we use the fork in `dotty-staging`. For some reason this reference was never updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that changing submodule URLs may cause infrastructure problems for existing clones, need to run git submodule sync
and then git submodule update
.
Can we just use lampepfl/xml-interpolator
, and remove dotty-staging/xml-interpolator
?
We cannot use Additionally, this is the only project that currently does not use the scheme we have for every submodule. There is no reason to have an exception. |
I don't mind creating a fork in If I remember correctly, we fork projects for community projects when we don't have control. In the long run, the forks will diminish. |
It is not only for control. It is also to have a project where we can create any change without polluting the main project while not having our own forks. We have done the mistake of creating branches If we only had |
Because of the past mistake, we now have 17 extra branches that should be removed in https://github.com/lampepfl/xml-interpolator/branches. These need to be cleaned up. |
Note that we cannot remove any commit which is referenced by a past version of dotty. |
At least we can stop adding more random branches now |
Strong argument for having them in |
All those branches have been merged at some point. I will make a backup in |
In practice, we do not need these commits for versions of Dotty lower than the current RC. This is because the only place we need them is when promoting RC to a stable version. Doing so invokes community tests which can get confused if they don't find the commit we deleted. Nobody runs the tests for commits other than during such a promotion.
Note that the hashes of the commits change on any push that cannot be executed without |
We started having it on in
lampepfl
but now that we need to update it from type to timewe use the fork in
dotty-staging
. For some reason this reference was never updated.