Fix quote match leak #8551
Merged
Fix quote match leak #8551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-quote-match-leak
branch
from
7f16383 to
9f168ea
Compare
nicolasstucki
force-pushed
the
fix-quote-match-leak
branch
4 times, most recently
from
9dcf828 to
8767f8e
Compare
And make `inlineContext` resilient to previous errors (i.e. never add an empty call).
nicolasstucki
force-pushed
the
fix-quote-match-leak
branch
from
8767f8e to
b35f6a6
Compare
|
The leak in question where trees defined outside the macro expansion that where accidentally brought in scope by the pattern matcher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix quote match leak due to use of
underlyingArgumentand makeinlineContextresilient to previous errors (i.e. never add an empty call).Tests were fixed in #8553 to not rely on
underlyingArgument.