Skip to content

Refactor splice internals #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Mar 10, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review March 10, 2020 15:28
@nicolasstucki nicolasstucki force-pushed the refactor-splice-internals branch from 8a04428 to b81a6c7 Compare March 10, 2020 15:54
Inline, remove dead code and simplify computations splice type
@nicolasstucki nicolasstucki force-pushed the refactor-splice-internals branch from b81a6c7 to dc0b387 Compare March 10, 2020 15:57
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.appliedToTypes(List(tpt1.tpe, defn.QuoteContextClass.typeRef))
.appliedTo(Typed(pat, exprTpt))
transform(newSplice)
case Apply(fn, pat :: Nil) if fn.symbol == defn.InternalQuoted_exprSplice =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to use quoted pattern matching here 😄

@nicolasstucki nicolasstucki merged commit aa0c87b into scala:master Mar 11, 2020
@nicolasstucki nicolasstucki deleted the refactor-splice-internals branch March 11, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants