Remove quoted.matching.Sym #8486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Mar 10, 2020
| @@ -14,22 +14,22 @@ object Test { | |||
| case '{ 1 + ($y: Int)} => y | |||
| case '{ val a = 1 + ($y: Int); 3 } => y | |||
| case '{ val $y: Int = $z; println(`$y`); 1 } => | |||
| val a: quoted.matching.Sym[Int] = y | |||
| val a: String = y | |||
There was a problem hiding this comment.
If y is String, the semantics for the reference to y in println($y) becomes problematic.
There was a problem hiding this comment.
Why? Could you elaborate
There was a problem hiding this comment.
After discussion, now I see the $y in val $y = e has double meaning.
There was a problem hiding this comment.
In general, a $ can be in an expression position (Expr[T]), type position (Type[T]) or definition position (String)
liufengyun
approved these changes
Mar 10, 2020
| @@ -14,22 +14,22 @@ object Test { | |||
| case '{ 1 + ($y: Int)} => y | |||
| case '{ val a = 1 + ($y: Int); 3 } => y | |||
| case '{ val $y: Int = $z; println(`$y`); 1 } => | |||
| val a: quoted.matching.Sym[Int] = y | |||
| val a: String = y | |||
There was a problem hiding this comment.
After discussion, now I see the $y in val $y = e has double meaning.
Since quoted patterns do not return open quotes, this abstraction does not have any purpose. The only useful part of it is extracting the name of a binding, therefore instead of returning a Sym we return the name as a String directly.
nicolasstucki
force-pushed
the
remove-quoted-matching-sym
branch
from
27c00df to
721223f
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since quoted patterns do not return open quotes, this abstraction does not have any purpose.
The only useful part of it is extracting the name of a binding, therefore instead of returning a Sym we return the name as a String directly.