Skip to content

Fix #8460: expose children of sealed trait in Reflection #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2020
Merged

Fix #8460: expose children of sealed trait in Reflection #8461

merged 1 commit into from
Mar 8, 2020

Conversation

gzoller
Copy link
Contributor

@gzoller gzoller commented Mar 7, 2020

Allow Symbol in Reflection to get the children (case classes or case objects) of a sealed trait.

dottybot
dottybot reviewed Mar 7, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@gzoller
Copy link
Contributor Author

gzoller commented Mar 7, 2020

fixes #8460

@liufengyun liufengyun requested a review from nicolasstucki March 7, 2020 08:16
@nicolasstucki nicolasstucki merged commit 7415f66 into scala:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gzoller @nicolasstucki @dottybot