Fix #8425: Avoid race between erasure and explicit outer #8433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/8433/ to see the changes. Benchmarks is based on merging with master (0954a07) |
RefChecks would invoke ignoreDeferred each time we hit an abstract member in a base class of a checked class, which means almost all of the time. ignoreDeferred would in turn do time travel to post-erasure. This causes inefficiencies because of compiler-context switches. It also exposed the problem in i8425 that was fixed by the last commit. The concrete failure for i8425 does go away with the change in this commit. However, the fix in the last commit is still necessary since explicit outer/erasure races are a general problem that could come back.
smarter
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.