Skip to content

Fix #8314: Define TupleXXL equals and hashCode as in case classes #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix #8314: Define TupleXXL equals and hashCode as in case classes #8316

merged 1 commit into from
Mar 4, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Feb 14, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review February 15, 2020 07:40
@nicolasstucki nicolasstucki linked an issue Feb 17, 2020 that may be closed by this pull request
TupleXXL should use BoxesRunTime instead of java.util.Arrays.{deepEquals, deepHashCode} #8314
Closed
smarter
smarter requested changes Feb 22, 2020
View reviewed changes
library/src/scala/runtime/TupleXXL.scala Outdated

override def toString: String = elems.asInstanceOf[Array[Object]].mkString("(", ",", ")")

override def hashCode: Int = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For case classes we normally delegate to scala.runtime.ScalaRunTime._hashCode, couldn't we do this here too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can.

Though we do not seem to be delegating ti this method for case classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we do not seem to be delegating ti this method for case classes.

We do: https://github.com/lampepfl/dotty/blob/04042381ff99039884cd85d87e22f1463b8133cf/compiler/src/dotty/tools/dotc/transform/SyntheticMembers.scala#L284

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that I saw some code generated in the hashCode, which I used as a template for the first implementation. Maybe we are optimizing by mistake something that we should not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a primitive type field in the case class we do write it by hand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then that was the case

OlivierBlanvillain
OlivierBlanvillain reviewed Feb 25, 2020
View reviewed changes
@nicolasstucki nicolasstucki requested a review from smarter March 4, 2020 12:49
@smarter smarter merged commit 7fd5d68 into scala:master Mar 4, 2020
@smarter smarter deleted the fix-#8314 branch March 4, 2020 12:54
@anatoliykmetyuk anatoliykmetyuk added this to the 0.23.0-RC1 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@OlivierBlanvillain OlivierBlanvillain OlivierBlanvillain approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
0.23.0-RC1
Development

Successfully merging this pull request may close these issues.

TupleXXL should use BoxesRunTime instead of java.util.Arrays.{deepEquals, deepHashCode}
4 participants
@nicolasstucki @smarter @OlivierBlanvillain @anatoliykmetyuk