Skip to content

Add Syntax Changes document #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 12, 2020

Add a doc page to explain how the syntax of previous Dotty versions
changed in 0.22.

Add a doc page to explain how the syntax of previous Dotty versions
changed in 0.22.
@odersky
Copy link
Contributor Author

odersky commented Feb 12, 2020

I think this should be kept as a doc page somewhere, but we don't need to link prominently to it. I put it under release-notes. Not sure whether there is a better place.

What's the doc tool doing these days? If we merge this PR, will it be accessible immediately? And under what URL?

import a.{given _}
import b.{_, given _}
```
The previous syntax, which used just `given` without an underscore is no longer supported. The change was made to better align with typed given import selectors such as `given Ordering[T]`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer supported

On 0.22.0-RC1, it's still possible to do import Foo.given https://scastie.scala-lang.org/SnWyIoLBROW2VI2kuq8kJA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 0.22 RC is maximally permissive. It's on master that the old forms are removed.

@anatoliykmetyuk anatoliykmetyuk merged commit 1681e2d into scala:master Feb 12, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the syntax-changes-doc branch February 12, 2020 13:18
@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Feb 12, 2020

@odersky the link should be http://dotty.epfl.ch/docs/release-notes/syntax-changes-0.22.html, the doc tool generates a website from everything in "docs/". It will become accessible after the next nightly build. If we don't explicitly put it in the sidebar YAML file, it won't appear there. Do we also need to update the 0.22 website snapshot to have that page (accessible via http://dotty.epfl.ch/0.22.0-RC1/docs/release-notes/syntax-changes-0.22.html)?

@odersky
Copy link
Contributor Author

odersky commented Feb 12, 2020

Thanks for the explanations. I'll make a post linking to the page tomorrow then. I don't see a reason why we should have it in the snapshot (or on the sidebar).

@anatoliykmetyuk anatoliykmetyuk added this to the 0.23.0-RC1 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants