Skip to content

Fix issue #8124 #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix issue #8124 #8279

merged 1 commit into from
Feb 11, 2020

Conversation

michelou
Copy link
Contributor

Also added two tests for dotc and dotd.

Updated behavior with dotd (crashed before fix):

> c:\opt\dotty-0.22.0-RC1\bin\dotd -project -project-url "http://" dummy.scala
-project -project-url "https://" dummy.scala
missing argument for option -project
  dotc -help  gives more information
Site project name not set. Use `-project <title>` to set the project name

Updated behavior with dotc (crashed before fix):

> c:\opt\dotty-0.22.0-RC1\bin\dotc -encoding -d c:\temp\classes dummy.scala
missing argument for option -encoding
  dotc -help  gives more information

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@smarter smarter merged commit a5f1dae into scala:master Feb 11, 2020
@smarter smarter linked an issue Feb 11, 2020 that may be closed by this pull request
@michelou michelou deleted the dotty-t8124 branch February 11, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotd/dotc do crash when an option value of type String is missing
3 participants