Fix #8033: Eliminate unnecessary outer accessors #8253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a necessary first step to be able to move the field into the class constructor
odersky
force-pushed
the
fix-#8033
branch
2 times, most recently
from
5cc5ae8 to
4cb1cda
Compare
The problem is that outer accessors can also be called from outside a class definition, e.g. as part of pattern matching or type testing. So we have to be more conservative where to remove them. A drastic measure is to restrict to anonaymous classes only, which is what this commit does.
We now also drop outer accessors of classes that are visible only in one toplevel class. This requires counting accessors in a complete traversal. We therefore need two phases in separate groups to do the job. The first phase counts, the second elimintaes accessors using the info gathered in the first phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.