Port Desugar error messages to the new scheme #8243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 7, 2020
ausmarton
force-pushed
the
ticket/1589
branch
2 times, most recently
from
327a3f1 to
2891bbd
Compare
ausmarton
force-pushed
the
ticket/1589
branch
from
2891bbd to
861f11a
Compare
felixmulder
reviewed
Feb 7, 2020
There was a problem hiding this comment.
Thanks for putting in the work on this ❤️
I'll defer work to the real maintainers 💪 @anatoliykmetyuk 🙏
|
Thank you, @felixmulder |
anatoliykmetyuk
approved these changes
Feb 7, 2020
|
Thanks for your work @ausmarton! |
|
@anatoliykmetyuk Thanks for reviewing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1589