Skip to content

Update message for erased function types #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Update message for erased function types #8239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,17 +2383,17 @@ object messages {
val explanation: String = ""
}

case class ImplicitTypesCanOnlyBeFunctionTypes()(implicit val ctx: Context)
case class ImplicitTypesCanOnlyBeFunctionTypes()(implicit val ctx: Context) // TODO remove when (given ...) => is removed
extends Message(ImplicitTypesCanOnlyBeFunctionTypesID) {
val kind: String = "Syntax"
val msg: String = "Types with given keyword can only be function types `given (...) => ...`"
val msg: String = "Types with given keyword can only be function types `(given ...) => ...`"
val explanation: String = ""
}

case class ErasedTypesCanOnlyBeFunctionTypes()(implicit val ctx: Context)
extends Message(ErasedTypesCanOnlyBeFunctionTypesID) {
val kind: String = "Syntax"
val msg: String = "Types with erased keyword can only be function types `erased (...) => ...`"
val msg: String = "Types with erased keyword can only be function types `(erased ...) => ...`"
val explanation: String = ""
}

Expand Down
4 changes: 2 additions & 2 deletions compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,7 +1699,7 @@ class ErrorMessagesTests extends ErrorMessagesTest {
implicit val ctx: Context = ictx
assertMessageCount(1, messages)
val ImplicitTypesCanOnlyBeFunctionTypes() :: Nil = messages
assertEquals("Types with given keyword can only be function types `given (...) => ...`", messages.head.msg)
assertEquals("Types with given keyword can only be function types `(given ...) => ...`", messages.head.msg)
}

@Test def erasedTypesCanOnlyBeFunctionTypesFailed() =
Expand All @@ -1708,7 +1708,7 @@ class ErrorMessagesTests extends ErrorMessagesTest {
implicit val ctx: Context = ictx
assertMessageCount(1, messages)
val ErasedTypesCanOnlyBeFunctionTypes() :: Nil = messages
assertEquals("Types with erased keyword can only be function types `erased (...) => ...`", messages.head.msg)
assertEquals("Types with erased keyword can only be function types `(erased ...) => ...`", messages.head.msg)
}

@Test def caseClassMissingParamListSuccessful =
Expand Down