Remove unneccassary cast to URLClassLoader, which breaks on JDK 11 #8230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 6, 2020
|
@odersky This would be useful to make Bloop able to compile Scala 3 on JDK 11 due to https://blog.codefx.org/java/java-11-migration-guide/#Casting-To-URL-Class-Loader Otherwise we are limited to JDK 8. PR in Bloop scalacenter/bloop#1165 |
smarter
approved these changes
Feb 6, 2020
|
Thanks @smarter ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to test failures on scalacenter/bloop#1165 and came up as a part of our work on making Metals work for Scala 3
Let me know if we should fix it a different way.