Skip to content

Use extensions for show* in Reflection #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 4, 2020
Merged

Use extensions for show* in Reflection #8190

merged 6 commits into from
Feb 4, 2020

Conversation

nicolasstucki
Copy link
Contributor

Workaround #8188 by renaming on of the show to showWith

@nicolasstucki nicolasstucki marked this pull request as ready for review February 4, 2020 11:10
liufengyun
liufengyun approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 96036af into scala:master Feb 4, 2020
@nicolasstucki nicolasstucki deleted the use-extension-in-reflection branch February 4, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun