Addressed issue 8163 to add opaque alias info to Reflection API #8176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 3, 2020
nicolasstucki
suggested changes
Feb 3, 2020
compiler/test/dotty/tools/dotc/BootstrappedOnlyCompilationTests.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/tastyreflect/ReflectionCompilerInterface.scala
Outdated
Show resolved
Hide resolved
|
Could you also mention |
|
linking #8163 |
|
requested changes complete |
nicolasstucki
approved these changes
Feb 4, 2020
|
Thank you #gzoller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Reflection API we needed a way to find out what the actual type of an opaque type alias is. This information is known to the compiler and just needed to be propagated to the Reflection API using the pattern set up already in CompilerInterface. I added 2 methods on Reflection's TypeRef. One method to test to see if the TypeRef refers to an opaque type alias, and another to return the actual Type of the alias.
This gap has been discussed on gitter.
I've signed the CLA.