Fix #8101: Change partially-augmented signalling #8116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
fix-#8101
branch
2 times, most recently
from
992049a to
603b3a4
Compare
|
I ended up using half of smarter@410adde |
since denotations are phase-versioned and later denotations might exist already when the flag of an earlier denotation is set. To avoid this, set flags in all following denotations, not just the current one.
anatoliykmetyuk
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags can't be used as non-monotonic signals between phases
since denotations are phase-versioned and later denotations
might exist already when the flag of an earlier denotation is
set. Use two flags instead of one to avoid the non-monotonic change.
Note: I could not make the test fail before doing this change, so I could not
see whether it works now. The test files are in run/i8101. @anatoliykmetyuk can
you verify that this works now, and possibly turn it into a proper test?