Fix #7048: Check for splice stability #8097
Conversation
nicolasstucki
force-pushed
the
fix-#7048
branch
3 times, most recently
from
780038e to
c3ec5d3
Compare
nicolasstucki
force-pushed
the
fix-#7048
branch
from
c3ec5d3 to
e29c481
Compare
| { | ||
| val s = '{Option.empty[${T}]} | ||
| val r = '{identity($s)} // works | ||
| val r2 = '{identity(${s: Expr[Option[T]]})} // error // error |
There was a problem hiding this comment.
It's not obvious why this is not accepted by the check.
There was a problem hiding this comment.
32 | val r2 = '{identity[Option[T]](${s: Expr[Option[T]]})} // error // error
| ^^^^^^^^^^^^^^^^^^^^^
| (Test.this.given_Type_T : => quoted.Type[Test.this.T]) is not stable
All these can be fixed by making the given stable
val getT: Type[T] = T // need this to avoid getting `null`
given getT.type = getTThere was a problem hiding this comment.
Added an extra test for it
There was a problem hiding this comment.
Why it has to be stable?
There was a problem hiding this comment.
Type splices require a stable prefix to be correctly encoded. It also avoids having to deal with side effects in the transformation performed in ReifyQuotes. Most code receives the quoted type as a parameter and hence is stable.
There was a problem hiding this comment.
It's a restriction in TASTy? This is unprecedented in Scala, as usually only the path in types needs to be stable.
There was a problem hiding this comment.
This is a path in a type. A type that is inferred and then healed.
No description provided.