Skip to content

WIP: Update CI cache to include Scala.js artifacts #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Jan 22, 2020

The scala-js sbt plugin downloads artifacts directly from maven,
bypassing our proxy (set using
https://github.com/lampepfl/dotty-drone/blob/master/dotty-docker/repositories),
this lead to us being banned from maven. I regenerated a docker image
with a cache containing these artfiacts.

@smarter
Copy link
Member Author

smarter commented Jan 22, 2020

@smarter
Copy link
Member Author

smarter commented Jan 22, 2020

Also is there a better way to trigger download of the linker than calling the scalaJSIR task which compiles a bunch of stuff ? It looks like the scalaJSLinker task cannot be called from the sbt repl. Ideally I think calling the update task should download everything needed to compile the code, including the linker.

@smarter smarter merged commit 7282a9b into scala:master Jan 22, 2020
@smarter smarter deleted the new-cache branch January 22, 2020 18:28
@dwijnand
Copy link
Member

It looks like the scalaJSLinker task cannot be called from the sbt repl.

The keys should be Compile / fastOptJS / scalaJSLinker and Compile / fullOptJS / scalaJSLinker. What do you get when you invoke them?

@smarter
Copy link
Member Author

smarter commented Jan 22, 2020

ah indeed, something like sjsJUnitTests/compile:fastOptJS::scalaJSLinker works.

@sjrd
Copy link
Member

sjrd commented Jan 22, 2020

any reason you're not using the default resolvers ?

Yes:
scala-js/scala-js#3805 (comment)

@smarter
Copy link
Member Author

smarter commented Jan 22, 2020

But couldn't you use ivyConfiguration.value which includes this stuff instead of making a custom InlineIvyConfiguration ? This is what we do in sbt-dotty.

@sjrd
Copy link
Member

sjrd commented Jan 22, 2020

Hum, perhaps. I'll try tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants