Fix #7401: Refine overloading resolution #7989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are left with several alternatives after normal overloadiong resolution and the expected result type is not a FunProto, prefer the alternatives that do not have a method result type. This makes i2378 compile, so it got moved to a pos test.
The error that was checked for in the test is no more.
The previous code did not compose correctly with the "no defaults" criterion that followed.
liufengyun
approved these changes
Jan 15, 2020
| // prefer alternatives that need no eta expansion | ||
| val noCurried = alts.filter(!resultIsMethod(_)) | ||
| val noCurriedCount = noCurried.length | ||
| if noCurried.length == 1 then |
There was a problem hiding this comment.
As pointed out by @michelou , we can just use noCurriedCount instead of noCurried.length .
liufengyun
reviewed
Jan 15, 2020
Co-Authored-By: Fengyun Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are left with several alternatives after normal overloadiong resolution
and the expected result type is not a FunProto, prefer the alternatives
that do not have a method result type. This makes i2378 compile, so it got
moved to a pos test.