Fix #7840: Don't instantiateSelected to Nothing #7845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When instantiating type variables ahead of an implicit search, avoid instantiating them to Nothing. These are really two changes: - Assert `avoidBottom` in `instantiateSelected` - Change FullyDefinedAccululator logic so that `avoidBottom` overrides `minimizeAll`.
odersky
force-pushed
the
fix-#7840
branch
3 times, most recently
from
9d373b3 to
80ca4c9
Compare
smarter
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiating type variables ahead of an implicit search, avoid instantiating
them to Nothing.
These are really two changes:
avoidBottomininstantiateSelectedavoidBottomoverridesminimizeAll.