Skip to content

IArray extension methods #7795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 29, 2019
Merged

IArray extension methods #7795

merged 12 commits into from
Dec 29, 2019

Conversation

brunnerant
Copy link
Contributor

This is work in progress, it doesn't work yet (in particular, the test time out for some unknown reason).

@nicolasstucki nicolasstucki self-requested a review December 17, 2019 19:27
@brunnerant
Copy link
Contributor Author

Should I copy all the documentation from ArrayOps.scala to the extension methods that I added ?

@nicolasstucki
Copy link
Contributor

Yes, that would be great

@nicolasstucki
Copy link
Contributor

BTW, #7806 will move the IArray file. This should in theory not be a conflict as it does not change its contents.

@nicolasstucki
Copy link
Contributor

The code LGTM. Just missing the documentation.

@brunnerant
Copy link
Contributor Author

Ok, I will do it as soon as possible !

@brunnerant
Copy link
Contributor Author

I just copied the comments from ArrayOps.scala (in Scala 2). Note that I only took the short description of the methods, not the entire documentation about the parameters and the return value.

@nicolasstucki nicolasstucki marked this pull request as ready for review December 29, 2019 09:28
@nicolasstucki nicolasstucki merged commit 08f70cb into scala:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants