Memoize: duplicate scala2 behaviour: don't create fields for final vals. #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
|
@odersky your proposed code will perform transformation when |
|
It is not yet ready for review. It fails the supposed test. |
|
@DarkDimius: No, notice the isPureExpr guard. That will do the right test, also for blocks. |
|
Rebased to master and added fixes to make this work. |
|
Also, applied my own earlier suggested patches. |
This affect initialisation order and we rely on artifacts of initialisation order in Dotty.
A TermRef representing a constant value needs to be considered a constant when folding.
Previously, a constant right hand side was not propagated to the type of a final val that implemented another val with a given type. The inherited type was used instead. This means final vals implementing abstract vals get evaluated too late.
Now, PostTyper replaces constant expressions with literals. If we wait any longer then any tree rewriting of an application node would have to do constant folding again, which is a hassle. With the previous late Literalize phase, constant expressions consisting of operations and arguments lost their constantness in PostTyper.
A constant expression with pure arguments is pure. Previously, this was not taken into account, which meant that literalize did not work for constant expressions contiaining primitive operations or String adds.
It produced just the right hand side literal before.
to test for propagation of constant types.
Check that calling a side effecting function returning a constant type does not get suppressed.
DarkDimius
force-pushed
the
final-vals2
branch
from
52ecdfd to
e491cfb
Compare
DarkDimius
added a commit
that referenced
this pull request
Sep 14, 2015
Memoize: duplicate scala2 behaviour: don't create fields for final vals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affect initialisation order and we rely on artifacts of initialisation order in Dotty.