Fix final vals #771
Merged
Fix final vals #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the parser needed to be updated. Everything else works out of the box.
This duplicates scalac behavior. Awaiting inline, this is a stopgap because we need this to work for the bootstrap. Once we have inline (and a migration tool that rewrites final to final inline) we can migrate this functionality over to inline values.
As the comment in pos/singletons.scala says, we currently test only constant propagation during typer. We should also have a test that literalize produces the literals in the right places.
It's decided that constant types and purity are independent.
Null and 'sym are not legal as singleton types because the underlying values are not stable. They are rejected now outright instead of issuing a cryptic "X is not stable" error message.
Tested are now other numeric values, strings, booleans, which are all legal singleton types.
Introduce a new non-terminal "SimpleLiteral". Only SimpleLiterals can be types.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of SIP 23 and fixes to constant propagation and code generation for constants. SIP 23 was added because it makes testing easier. Review by @DarkDimius