-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #7595: Redesign dottydoc theme #7612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7595: Redesign dottydoc theme #7612
Conversation
Lighter and closer to the old one instead of the front page. See issue scala#7595
1af1c4c
to
ac35b56
Compare
PS: this PR does not change the front page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't judge the changes looking at the source code since I don't know enough about the technologies used. Is there are way to pre-view the outcome? If not, I'd say let's just try it and tweak it later if necessary.
@odersky There are some screenshots in the "details" of the Theme Comparison and Font Choice sections. If you want to have the full website you can pull and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for taking the time to do this ! Using the same font that scala-lang uses makes sense to me.
I think it's a huge improvement! There's one thing we could still fiddle with: I have the impression the code font is a bit thin. If I compare with, say, the Rust Book, their code fonts seem to have a bit more weight. Can we achieve the same? |
The result looks great, thanks @TheElectronWill! The blog articles list still looks ugly in my opinion, though: What do you think of decreasing the font weight? |
I see what you mean. Hopefully I can just increase the font weight property and it will look nice, I'll try that.
I think it's the font size that especially needs some tweaking. The headings are way bigger than the posts' summaries. On mobile the first title takes almost 1/2 of the page! |
This PR:
Ligatures: Fira Code provides font ligatures, which I've disabled to avoid confusing people. I can enable them if you don't believe they will be a problem.
Text font: Nobody seems to dislike the current text font, but maybe you'd prefer another one?
EDIT: Lato is widely appreciated in the Scala community, and for me it increases readability over the current font. It also works very well with Fira Code.
Theme Comparison
New theme:

Font Choice
Please click on the image to open it in full size. Do you have a preference?
Current theme: Roboto Slab
Proposal (EDIT: applied in this PR): Lato
Alternative: Roboto or something else
Roboto Slab (current):
Lato (proposal - used by scala-lang.org and many Scala projects):

Roboto (used by the Rust Book):

I think this addresses most of the issues raised in #7595. Please tell me what you think! All comments are welcome.