Support simple higher order pattern splices #7591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
quoted-pattern-open-holes
branch
3 times, most recently
from
abafaea to
3be5d70
Compare
nicolasstucki
force-pushed
the
quoted-pattern-open-holes
branch
2 times, most recently
from
932d63c to
634e976
Compare
nicolasstucki
force-pushed
the
quoted-pattern-open-holes
branch
2 times, most recently
from
c81f0e1 to
8410346
Compare
nicolasstucki
force-pushed
the
quoted-pattern-open-holes
branch
from
8410346 to
b7937b8
Compare
liufengyun
approved these changes
Dec 5, 2019
| import qctx.tasty.{given, _} | ||
| val (params, bodyExpr) = paramsAndBody(f) | ||
| content(bodyExpr, [t] => (e: Expr[t]) => (v: Expr[T1]) => bodyFn[t](e.unseal, params, List(v.unseal)).seal.asInstanceOf[Expr[t]]) | ||
| } |
There was a problem hiding this comment.
It's not clear how open/close is useful. I'd suggest removing them for now.
There was a problem hiding this comment.
I cannot remove it without breaking some tests. I particular those that test the code infrastructure for what @biboudis is working on.
This fixes the quoted pattern matcher runtime to never return open code.
* `case '{ val x: Int = 3 ; $body }` will only match if body does not contain a reference to `x`. Same for other kind of definitions in the pattern.
* `case '{ val x: Int = 3; ($f: Int => Int)(x) }` will match any body of type `Int` but will wrap it in a lambda that contains `x` as an argument.
* Introduce `Expr.open` that takes a expression of a lambda and explicitly opens it temporarily an provides a way to re-close any subexpression of its body (unsafe if not used properly).
nicolasstucki
force-pushed
the
quoted-pattern-open-holes
branch
from
b7937b8 to
a5c1ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the quoted pattern matcher runtime to never return open code.
case '{ val x: Int = 3 ; $body }will only match ifbodydoes not contain a reference tox. Same for other kind of definitions in the pattern.case '{ val x: Int = 3; ($f: Int => Int)(x) }will match any body of typeIntbut will wrap it in a lambda that containsxas an argument.Expr.openthat takes a expression of a lambda and explicitly opens it temporarily an provides a way to re-close any subexpression of its body (unsafe if not used properly).